-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize DA verify_transactions #1481
Merged
eyusufatik
merged 13 commits into
nightly
from
yaziciahmet/optimize-verify-transactions
Nov 19, 2024
Merged
Optimize DA verify_transactions #1481
eyusufatik
merged 13 commits into
nightly
from
yaziciahmet/optimize-verify-transactions
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyusufatik
reviewed
Nov 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
I did some benchmarks locally, and on average optimized version consumes 0.5% less cycles. This test was only with 1 sequencer commitment, hence, I can safely say that more commitments will result in a greater cycle difference. |
kpp
reviewed
Nov 19, 2024
jfldde
reviewed
Nov 19, 2024
jfldde
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizes verify_transactions method of DA verifier.
Previously:
1.1. Validate wtxid
1.2. Ensure corresponding tx exists in inclusion proof
1.3. Collect completeness proof wtxids into a BTreeSet
2.1 If prefix matches, verify it also exists in collected completeness proof wtxids BTreeSet and remove it
New:
1.1 Verify wtxids match
With the new version, collecting and later removing wtxids into an BTreeSet is removed, and there is now only 1 iteration over proofs.
Linked Issues
Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?