Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offchain contract test #1459

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Offchain contract test #1459

merged 7 commits into from
Nov 13, 2024

Conversation

rakanalh
Copy link
Contributor

@rakanalh rakanalh commented Nov 11, 2024

Description

Adds a test to make sure that a contracts code is correct and that the contract is executing transactions properly pre and post forks.

Linked Issues

@rakanalh rakanalh marked this pull request as draft November 11, 2024 08:04
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.8%. Comparing base (c45741c) to head (abf2ce7).
Report is 1 commits behind head on nightly.

Additional details and impacted files
Files with missing lines Coverage Δ
crates/evm/src/evm/db.rs 75.2% <100.0%> (ø)
crates/evm/src/evm/db_commit.rs 92.8% <100.0%> (ø)
crates/evm/src/evm/db_init.rs 57.6% <100.0%> (ø)
crates/evm/src/genesis.rs 100.0% <ø> (ø)
crates/evm/src/query.rs 89.4% <100.0%> (ø)

... and 6 files with indirect coverage changes

@rakanalh rakanalh force-pushed the rakanalh/offchain-tests branch from 1bb1d47 to 54f4130 Compare November 12, 2024 04:54
@rakanalh rakanalh marked this pull request as ready for review November 12, 2024 04:55
@rakanalh rakanalh merged commit 17a677a into nightly Nov 13, 2024
14 of 15 checks passed
@rakanalh rakanalh deleted the rakanalh/offchain-tests branch November 13, 2024 17:02
};

{
let set_value_req = sequencer_client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should get the value and see if the tx actually worked. if the code couldn't be reached for example, the tx would go through but value wont be set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a test for offchain storage
3 participants