Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove TransactionReceipt::body_to_save from stf #1440

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Nov 7, 2024

Description

Don't keep TransactionReceipt::body_to_save in STF, instead pass it from outside.

Linked Issues

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.7%. Comparing base (de1732c) to head (285a26d).
Report is 2 commits behind head on nightly.

Additional details and impacted files
Files with missing lines Coverage Δ
bin/citrea/src/test_rpc.rs 99.5% <100.0%> (+0.5%) ⬆️
crates/batch-prover/src/runner.rs 90.0% <100.0%> (+0.1%) ⬆️
crates/fullnode/src/runner.rs 88.8% <100.0%> (+<0.1%) ⬆️
crates/sequencer/src/runner.rs 90.4% <100.0%> (+0.2%) ⬆️
...reign-sdk/full-node/db/sov-db/src/ledger_db/mod.rs 72.2% <100.0%> (+0.7%) ⬆️
...ereign-sdk/full-node/db/sov-db/src/schema/types.rs 62.5% <ø> (-2.5%) ⬇️
...tem/sov-modules-stf-blueprint/src/stf_blueprint.rs 78.5% <ø> (ø)
...eign-sdk/rollup-interface/src/state_machine/stf.rs 26.3% <ø> (ø)
.../rollup-interface/src/state_machine/stf/fuzzing.rs 0.0% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small looking but very important pr

@eyusufatik eyusufatik merged commit 8ce50c6 into nightly Nov 7, 2024
13 of 14 checks passed
@eyusufatik eyusufatik deleted the kpp/stf-no-keep-txbody branch November 7, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove TransactionReceipt::body_to_save from stf
2 participants