Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return reference from SignedSoftConfirmation fields #1431

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

yaziciahmet
Copy link
Contributor

@yaziciahmet yaziciahmet commented Nov 5, 2024

Description

Return reference from SignedSoftConfirmation fields, and clone them whenever the caller needs to. Also changes the txs input to apply_soft_confirmation_txs be a slice so we can avoid cloning it in couple of places. This could be useful specifically for txs since it potentially can be really big.

Linked Issues

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.9%. Comparing base (3cd79b6) to head (c2f380b).
Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
...p-interface/src/state_machine/soft_confirmation.rs 75.0% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/sequencer/src/runner.rs 94.0% <100.0%> (ø)
...ign-sdk/module-system/sov-modules-api/src/hooks.rs 79.5% <100.0%> (ø)
...module-system/sov-modules-stf-blueprint/src/lib.rs 49.1% <100.0%> (ø)
...tem/sov-modules-stf-blueprint/src/stf_blueprint.rs 78.5% <ø> (ø)
...p-interface/src/state_machine/soft_confirmation.rs 90.3% <75.0%> (-0.3%) ⬇️

... and 1 file with indirect coverage changes

@eyusufatik eyusufatik merged commit 0b07b0a into nightly Nov 5, 2024
13 of 14 checks passed
@eyusufatik eyusufatik deleted the yaziciahmet/ref-from-signed-soft-confirmation branch November 5, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignedSoftConfirmation::txs always clones
2 participants