Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add final soft confirmation hash to batch proof output #1427

Conversation

eyusufatik
Copy link
Member

Closes #1423

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 76.8%. Comparing base (4f86cea) to head (8e0427d).
Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/citrea-stf/src/verifier.rs 0.0% 13 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/batch-prover/src/proving.rs 89.5% <100.0%> (-1.4%) ⬇️
...n-sdk/rollup-interface/src/state_machine/zk/mod.rs 50.0% <ø> (ø)
crates/citrea-stf/src/verifier.rs 0.0% <0.0%> (ø)

... and 5 files with indirect coverage changes

@eyusufatik eyusufatik merged commit f25cbd1 into nightly Nov 5, 2024
13 of 14 checks passed
@eyusufatik eyusufatik deleted the esad/add-final-soft-confirmation-hash-to-batch-proof-output branch November 5, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output final soft confirmation hash in batch proof
3 participants