Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify risc0 host #1411

Merged
merged 11 commits into from
Nov 4, 2024
Merged

simplify risc0 host #1411

merged 11 commits into from
Nov 4, 2024

Conversation

eyusufatik
Copy link
Member

Description

Uses env vars for local / ipc / bonsai prover selection as risc0 intended.

the checks in Risc0BonsaiHost::new is not necessary actually but makes our program fail faster.

Linked Issues

Closes #1381

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 63.75000% with 58 lines in your changes missing coverage. Please review.

Project coverage is 77.1%. Comparing base (4a45df5) to head (13c25bf).
Report is 2 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/risc0/src/host.rs 72.6% 38 Missing ⚠️
crates/risc0/src/guest.rs 0.0% 18 Missing ⚠️
bin/citrea/src/rollup/bitcoin.rs 0.0% 1 Missing ⚠️
bin/citrea/src/rollup/mock.rs 50.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/risc0/src/lib.rs 0.0% <ø> (ø)
bin/citrea/src/rollup/bitcoin.rs 0.0% <0.0%> (ø)
bin/citrea/src/rollup/mock.rs 73.1% <50.0%> (+2.1%) ⬆️
crates/risc0/src/guest.rs 0.0% <0.0%> (ø)
crates/risc0/src/host.rs 72.6% <72.6%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@kpp kpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Then it's not a risc0-bonsai anymore, it's just risc0

@yaziciahmet
Copy link
Contributor

Roll alloy-chains and async-compression back and your lockfile should be fixed.

Copy link
Contributor

@yaziciahmet yaziciahmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyusufatik eyusufatik merged commit 85efd0d into nightly Nov 4, 2024
13 of 14 checks passed
@eyusufatik eyusufatik deleted the esad/simplify-risc0-host branch November 4, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use risc0's BonsaiProver
5 participants