Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MerkleProofSpec #1366

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Remove MerkleProofSpec #1366

merged 4 commits into from
Oct 23, 2024

Conversation

exeokan
Copy link
Contributor

@exeokan exeokan commented Oct 22, 2024

Description

Removes the trait MerkleProofSpec, and instead of generic parameters, uses DefaultWitness and DefaultHasher in ProverStorage.

Linked Issues

@exeokan exeokan marked this pull request as ready for review October 22, 2024 13:53
@@ -29,7 +29,7 @@

// pub(crate) fn create_storage_manager_for_tests(
// path: impl AsRef<Path>,
// ) -> ProverStorageManager<MockDaSpec, DefaultStorageSpec> {
// ) -> ProverStorageManager<MockDaSpec, DefaultWitness, DefaultHasher> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (e7d18d2) to head (4953c47).
Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
...-sdk/module-system/sov-state/src/prover_storage.rs 62.5% 3 Missing ⚠️
...eign-sdk/module-system/sov-state/src/zk_storage.rs 40.0% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
bin/citrea/src/eth.rs 100.0% <100.0%> (ø)
bin/citrea/src/rollup/bitcoin.rs 0.0% <ø> (ø)
bin/citrea/src/rollup/mock.rs 95.7% <ø> (ø)
...dk/full-node/sov-prover-storage-manager/src/lib.rs 97.3% <100.0%> (-0.1%) ⬇️
...odule-system/sov-modules-api/src/containers/mod.rs 100.0% <100.0%> (ø)
...dule-system/sov-modules-api/src/default_context.rs 69.4% <ø> (ø)
...-sdk/module-system/sov-state/src/prover_storage.rs 85.2% <62.5%> (-0.5%) ⬇️
...eign-sdk/module-system/sov-state/src/zk_storage.rs 62.0% <40.0%> (ø)

... and 1 file with indirect coverage changes

@eyusufatik eyusufatik merged commit 07729cc into nightly Oct 23, 2024
13 of 14 checks passed
@eyusufatik eyusufatik deleted the ege/remove-merkle-proof-spec branch October 23, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove trait MerkleProofSpec
4 participants