Error in helm chart. Namespace in role and rolebinding is wrong

[oleksiyp]

# Source: trust-manager/templates/rolebinding.yaml
kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: trust-manager
  namespace: cert-manager
  labels:
    app.kubernetes.io/name: trust-manager
    helm.sh/chart: trust-manager-v0.12.0
    app.kubernetes.io/instance: trust-manager
    app.kubernetes.io/version: "v0.12.0"
    app.kubernetes.io/managed-by: Helm
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: Role
  name: trust-manager
subjects:
- kind: ServiceAccount
  name: trust-manager
  namespace: infra

[erikgb]

@oleksiyp Why do you think the namespace is wrong? There are two relevant namespaces for trust-manager:

• Namespace where trust-manager is installed
• Namespace where sources to trust bundles are looked up

[oleksiyp]

I see... would expect all default to {{ .Release Namespace }} but not hardcoded sob., 12 paź 2024, 16:12 użytkownik Erik Godding Boye < ***@***.***> napisał:

…

@oleksiyp <https://github.com/oleksiyp> Why do you think the namespace is wrong? There are two relevant namespaces for trust-manager: - Namespace where trust-manager is installed - Namespace where sources to trust bundles are looked up — Reply to this email directly, view it on GitHub <#454 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIBXDDRQ2KXKYIEBYUC24LZ3EU6RAVCNFSM6AAAAABP2GHDEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGU3TQOJTGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[erikgb]

It is not hard-coded. A user can set both namespaces using values.

Are you ok to close this issue?

[oleksiyp]

yes niedz., 13 paź 2024, 18:04 użytkownik Erik Godding Boye < ***@***.***> napisał:

…

It is not hard-closed. A user can set both namespaces using values. Are you ok to close this issue? — Reply to this email directly, view it on GitHub <#454 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIBXDF5XZU6OUE5V6SEOOTZ3KK2JAVCNFSM6AAAAABP2GHDEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBZGAZTEOBYG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[oleksiyp]

Just inconveniece niedz., 13 paź 2024, 18:11 użytkownik O. Pylypenko < ***@***.***> napisał:

…

yes niedz., 13 paź 2024, 18:04 użytkownik Erik Godding Boye < ***@***.***> napisał: > It is not hard-closed. A user can set both namespaces using values. > > Are you ok to close this issue? > > — > Reply to this email directly, view it on GitHub > <#454 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABIBXDF5XZU6OUE5V6SEOOTZ3KK2JAVCNFSM6AAAAABP2GHDEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBZGAZTEOBYG4> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[erikgb]

We might do some changes in this area. See #60 (comment). But I am going to close this issue as it is described. A user can select the trust namespace independently of the Helm release namespace.

/close

[cert-manager-prow]

@erikgb: Closing this issue.

In response to this:

We might do some changes in this area. See #60 (comment). But I am going to close this issue as it is described. A user can select the trust namespace independently of the Helm release namespace.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.