task/internal/__init__.py: Revisit core program extraction regex #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idryomov
reviewed
Feb 18, 2025
Fixes: https://tracker.ceph.com/issues/61586 Signed-off-by: Brad Hubbard <[email protected]>
idryomov
approved these changes
Feb 19, 2025
kshtsk
reviewed
Feb 26, 2025
| @@ -334,7 +334,7 @@ def fetch_binaries_for_coredumps(path, remote): | |||
| log.error(e) | |||
| continue | |||
| try: | |||
| dump_program = re.findall("from '([^']+)'", dump_out)[0] | |||
| dump_program = re.findall("from '([^ ']+)", dump_out)[0] | |||
There was a problem hiding this comment.
or it is just missed .split()[0] at the end, however, for better readability maybe elaborate the code, like:
dump_command = re.findall("from '([^']+)", dump_out)[0]
dump_program = dump_command.split()[0]
If you like you could apply, however, I don't mind to merge it right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/61586