[WIP] RBD: retain temp snap #5191
Draft
+82
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Ceph-CSI deletes intermediate RBD snapshot on temporary cloned images (`csi-vol-xxxx-temp@csi-vol-xxxx`) which is the parent of the final clone image. The parent-child mirroring requires both the parent and child images to be present (i.e, not in trash). This commit makes enhancement to `createRBDClone` function by introducing `deleteSnap` parameter. If `deleteSnap` is true, the snapshot is deleted after the clone is created. This is required to support mirroring of child image with its parent image. Signed-off-by: Praveen M <[email protected]>
iPraveenParihar
force-pushed
the
rbd/retain-temp-snap
branch
from
ebd3b12 to
08d022a
Compare
|
/test ci/centos/mini-e2e/k8s-1.30 |
Signed-off-by: Praveen M <[email protected]>
iPraveenParihar
force-pushed
the
rbd/retain-temp-snap
branch
from
08d022a to
b796cb4
Compare
|
/test ci/centos/mini-e2e/k8s-1.30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Currently, Ceph-CSI deletes RBD snapshot on temporary
cloned image (
csi-vol-xxxx-temp@csi-vol-xxxx) which isthe parent of the final clone image.
The parent-child mirroring requires both the parent and child
images to be present (i.e, not in trash).
This commit makes enhancement to
createRBDClonefunction byintroducing
deleteSnapparameter. IfdeleteSnapis true,the snapshot is deleted after the clone is created.
This is required to support mirroring of child image with its
parent image.
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)