Overlapping text (Re-open #2993) #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claud-io
reviewed
Nov 7, 2023
| @@ -416,7 +416,7 @@ wpt-header .wptheader_nav_menu details[open] summary span:after { | |||
|
|
|||
| @media (min-width: 86em) { | |||
| wpt-header { | |||
| z-index: 999999; | |||
| z-index: 1000; | |||
There was a problem hiding this comment.
those changes are going to impact header everywhere have you checked with multiple resolutions?
claud-io
reviewed
Nov 7, 2023
| @@ -189,6 +189,20 @@ body.theme-b { | |||
| border: 0; | |||
| } | |||
|
|
|||
| .contact-info-modal { | |||
| height: 38rem !important; | |||
claud-io
reviewed
Nov 7, 2023
| @@ -31,8 +31,10 @@ | |||
| <input type="hidden" name="id" value="<?= $id; ?>" /> | |||
| <input type="hidden" name="type" value="contact-info" /> | |||
| <input type="hidden" name="csrf_token" value="<?= $csrf_token ?>" /> | |||
| <div class="save-button"> | |||
| <button type="submit" class="pill-button blue">Save</button> | |||
| <div class="section"> | |||
There was a problem hiding this comment.
what's the effect of this section class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening #2993. Apparently, it closes at re-naming the branch
With the first commit, I intended not to break anything and test how it behaves and look for impacts, since there are places I cannot check locally. It truly seems rare this new change won't cause any break, but those places are what I'm trying to find.
Please let me know if there's a more certain way to solve this that I'm not seeing.
@claud-io