Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't count LH as a test run if standard WPT test is run #2615

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

tkadlec
Copy link
Contributor

@tkadlec tkadlec commented Jan 4, 2023

We're no longer going to be counting Lighthouse runs as a separate run when selected alongside a standard WebPageTest result.

This change makes sure that if a standard test is run, running LH has no change on the test run count. However if only LH is run, it should count against users test run limits.

…n when selected alongside a standard WebPageTest result.

This change makes sure that if a standard test is run, running LH has no change on the test run count. However if only LH is run, it should count against users test run limits.
@tkadlec tkadlec requested a review from jefflembeck January 4, 2023 15:53
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it

@tkadlec tkadlec merged commit b0e07db into master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants