Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#1463] Element.contentEditable should be synced with the "contenteditable" attribute #1757

Conversation

karpiuMG
Copy link
Contributor

@karpiuMG karpiuMG commented Mar 1, 2025

…r is invoked

close #1463

I've added error throwing to mirror Chrome's behavior

@karpiuMG karpiuMG requested a review from capricorn86 as a code owner March 1, 2025 19:37
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you contribution @karpiuMG! ⭐

I have pushed in some fixes to the implementation, so that it works according to spec.

@capricorn86 capricorn86 changed the title fix: [#1463] Set contenteditable attribute when contentEditable sette… fix: [#1463] Element.contentEditable should be synced with the "contenteditable" attribute Mar 6, 2025
@capricorn86 capricorn86 merged commit 1417bad into capricorn86:master Mar 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTMLElement.contentEditable should apply the contenteditable attribute.
2 participants