Feature 1502 fetch test improvements #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-1502-fetch-test-improvements # Conflicts: # packages/happy-dom/test/fetch/Fetch.test.ts
…viSau/happy-dom into feature-1502-fetch-test-improvements
OlaviSau
force-pushed
the
feature-1502-fetch-test-improvements
branch
from
5153033 to
da50ea0
Compare
capricorn86
requested changes
Jan 23, 2025
| if (event === 'response') { | ||
| callback(response); | ||
| const response = <HTTP.IncomingMessage>Stream.Readable.from(generate()); | ||
| Object.assign(response, { headers: {}, rawHeaders: [] }, extra); |
There was a problem hiding this comment.
It may be useful if it defaults to 200 OK as this is the most common response.
| mockModule(schema, { | ||
| request: (url: string, options: HTTP.RequestOptions) => { | ||
| const request = { url, options }; | ||
| requestHistory = [...requestHistory, request]; |
There was a problem hiding this comment.
Any reason for not using requestHistory.push() here?
| }); | ||
| return { |
There was a problem hiding this comment.
Perhaps beforeResponse can be sent in as a parameter to the mockNetwork() function.
I that case it might be more convenient to use an object for the parameters:
function mockNetwork(options: { schema: 'http' | 'https'; responseText?: string: string[]; statusCode?: number; statusMessage?: string; headers?: { [k: string]: string }; rawHeaders?: string[]; beforeResponse: IBeforeResponseHook }): IRequestHistoryEntry[]There was a problem hiding this comment.
Converted to object :)
There was a problem hiding this comment.
Nice :)
I think we will need to be able to send in statusCode, statusMessage and headers as well
OlaviSau
force-pushed
the
feature-1502-fetch-test-improvements
branch
2 times, most recently
from
aa241a1 to
80afe5e
Compare
OlaviSau
force-pushed
the
feature-1502-fetch-test-improvements
branch
from
80afe5e to
12a6ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made mockNetwork even more flexible in order to accommodate more tests. Doing another intermediate PR for easier review.