happy-dom v16 with vitest throws: TypeError: Cannot read properties of null (reading 'Symbol(nodeArray)') #1663

viceice · 2025-01-03T14:56:01Z

Describe the bug
We're getting TypeError: Cannot read properties of null (reading 'Symbol(nodeArray)') error when using happy-dom v16 with vitest

TypeError: Cannot read properties of null (reading 'Symbol(nodeArray)')
 ❯ GlobalWindow.[destroy] node_modules/happy-dom/src/window/BrowserWindow.ts:1704:40
 ❯ GlobalWindow.close node_modules/happy-dom/src/window/BrowserWindow.ts:1256:32
 ❯ teardownWindow node_modules/vitest/dist/chunks/index.K90BXFOx.js:364:9
 ❯ Object.teardown node_modules/vitest/dist/chunks/index.K90BXFOx.js:415:9
 ❯ withEnv node_modules/vitest/dist/chunks/runBaseTests.3qpJUEJM.js:94:5
 ❯ run node_modules/vitest/dist/chunks/runBaseTests.3qpJUEJM.js:112:3
 ❯ runBaseTests node_modules/vitest/dist/chunks/base.BZZh4cSm.js:29:3
 ❯ ForksBaseWorker.executeTests node_modules/vitest/dist/workers/forks.js:27:7
 ❯ execute node_modules/vitest/dist/worker.js:127:5
 ❯ onMessage node_modules/tinypool/dist/entry/process.js:55:20

To Reproduce
Steps to reproduce the behavior:

checkout https://codeberg.org/forgejo/forgejo/pulls/6454
run make test-frontend
See error

Expected behavior
happy-dom should not throw on destroy.

Screenshots
not applicable

Device:

OS: Linux
Browser: NodeJS
Version: v22.12.0

Additional context
none

The text was updated successfully, but these errors were encountered:

viceice · 2025-01-07T10:48:08Z

It seems the document doesn't has a body here

happy-dom/packages/happy-dom/src/window/BrowserWindow.ts

Line 1704 in 5039b05

const childNodes = this.document.body[PropertySymbol.nodeArray];

viceice · 2025-01-07T11:05:09Z

this code will cause the error:

document.documentElement.innerHTML = '<head></head><body></body>';

this will set document.body to null

…HTML isnt parsed correctly since v16

…HTML isnt parsed correctly since v16 (#1671)

capricorn86 · 2025-01-07T23:44:02Z

Thank you for reporting @viceice! 🙂

This has been fixed now in v16.4.1

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [happy-dom](https://github.com/capricorn86/happy-dom) | devDependencies | minor | [`16.3.0` -> `16.8.1`](https://renovatebot.com/diffs/npm/happy-dom/16.3.0/16.8.1) | --- ### Release Notes <details> <summary>capricorn86/happy-dom (happy-dom)</summary> ### [`v16.8.1`](https://github.com/capricorn86/happy-dom/releases/tag/v16.8.1) [Compare Source](capricorn86/happy-dom@v16.8.0...v16.8.1) ##### 👷‍♂️ Patch fixes - Handle non-string values gracefully when removing an attribute - By **[@OlaviSau](https://github.com/OlaviSau)** in task [#1706](capricorn86/happy-dom#1706) ### [`v16.8.0`](https://github.com/capricorn86/happy-dom/releases/tag/v16.8.0) [Compare Source](capricorn86/happy-dom@v16.7.3...v16.8.0) ##### 🎨 Features - Add support for `insertRow()` and `deleteRow()` to `HTMLTableSectionElement` - By **[@christiango](https://github.com/christiango)** in task [#1708](capricorn86/happy-dom#1708) ### [`v16.7.3`](https://github.com/capricorn86/happy-dom/releases/tag/v16.7.3) [Compare Source](capricorn86/happy-dom@v16.7.2...v16.7.3) ##### 👷‍♂️ Patch fixes - Removes space from directory name that prevents the repo to be cloned on MS Windows - By **[@kleinfreund](https://github.com/kleinfreund)** in task [#1703](capricorn86/happy-dom#1703) ### [`v16.7.2`](https://github.com/capricorn86/happy-dom/releases/tag/v16.7.2) [Compare Source](capricorn86/happy-dom@v16.7.1...v16.7.2) ##### 👷‍♂️ Patch fixes - Ignore invalid cookies in CookieContainer - By **[@capricorn86](https://github.com/capricorn86)** in task [#1693](capricorn86/happy-dom#1693) ### [`v16.7.1`](https://github.com/capricorn86/happy-dom/releases/tag/v16.7.1) [Compare Source](capricorn86/happy-dom@v16.7.0...v16.7.1) ##### 👷‍♂️ Patch fixes - Adds `ICookie`, `IOptionalCookie`, `CookieSameSiteEnum` and `IVirtualServer` as exports to the index file - By **[@capricorn86](https://github.com/capricorn86)** in task [#1693](capricorn86/happy-dom#1693) - Makes non-mandatory cookie properties optional in `CookieContainer.addCookies()` - By **[@capricorn86](https://github.com/capricorn86)** in task [#1693](capricorn86/happy-dom#1693) ### [`v16.7.0`](https://github.com/capricorn86/happy-dom/releases/tag/v16.7.0) [Compare Source](capricorn86/happy-dom@v16.6.0...v16.7.0) ##### 🎨 Features - Adds support for simulating local HTTP servers that serves files from the local file system - By **[@capricorn86](https://github.com/capricorn86)** in task [#1688](capricorn86/happy-dom#1688) - Read more about virtual servers in the [Wiki](https://github.com/capricorn86/happy-dom/wiki/IVirtualServer) ### [`v16.6.0`](https://github.com/capricorn86/happy-dom/releases/tag/v16.6.0) [Compare Source](capricorn86/happy-dom@v16.5.3...v16.6.0) ##### 🎨 Features - Adds support for subsequent sibling combinator to `querySelector()`, `querySelectorAll()` and `matches()` (e.g. ".a ~ .b") - By **[@karpiuMG](https://github.com/karpiuMG)** in task [#1683](capricorn86/happy-dom#1683) ### [`v16.5.3`](https://github.com/capricorn86/happy-dom/releases/tag/v16.5.3) [Compare Source](capricorn86/happy-dom@v16.5.2...v16.5.3) ##### 👷‍♂️ Patch fixes - Fixes problem with encoding and decoding attribute values in HTML - By **[@capricorn86](https://github.com/capricorn86)** in task [#1678](capricorn86/happy-dom#1678) - Fixes issue where it was not possible to query selector by class when the attribute value had line breaks in it - By **[@capricorn86](https://github.com/capricorn86)** in task [#1678](capricorn86/happy-dom#1678) ### [`v16.5.2`](https://github.com/capricorn86/happy-dom/releases/tag/v16.5.2) [Compare Source](capricorn86/happy-dom@v16.5.1...v16.5.2) ##### 👷‍♂️ Patch fixes - `Event.target` should be the target element after an event has been dispatched - By **[@capricorn86](https://github.com/capricorn86)** in task [#1529](capricorn86/happy-dom#1529) ### [`v16.5.1`](https://github.com/capricorn86/happy-dom/releases/tag/v16.5.1) [Compare Source](capricorn86/happy-dom@v16.5.0...v16.5.1) ##### 👷‍♂️ Patch fixes - Fixes issue where `Comment`, `Text` and `DocumentFragment` are not instances of their corresponding property on `Window` - By **[@capricorn86](https://github.com/capricorn86)** in task [#1577](capricorn86/happy-dom#1577) ### [`v16.5.0`](https://github.com/capricorn86/happy-dom/releases/tag/v16.5.0) [Compare Source](capricorn86/happy-dom@v16.4.3...v16.5.0) ##### 🎨 Features - Adds property `GlobalRegistrator.isRegistered` - By **[@capricorn86](https://github.com/capricorn86)** in task [#1670](capricorn86/happy-dom#1670) ### [`v16.4.3`](https://github.com/capricorn86/happy-dom/releases/tag/v16.4.3) [Compare Source](capricorn86/happy-dom@v16.4.2...v16.4.3) ##### 👷‍♂️ Patch fixes - Adds null check for if browser frame is available in `Response` during tear down of the `Window` - By **[@capricorn86](https://github.com/capricorn86)** in task [#1669](capricorn86/happy-dom#1669) ### [`v16.4.2`](https://github.com/capricorn86/happy-dom/releases/tag/v16.4.2) [Compare Source](capricorn86/happy-dom@v16.4.1...v16.4.2) ##### 👷‍♂️ Patch fixes - Support using URL as an object for URL:s when using the Browser API - By **[@capricorn86](https://github.com/capricorn86)** in task [#1664](capricorn86/happy-dom#1664) ### [`v16.4.1`](https://github.com/capricorn86/happy-dom/releases/tag/v16.4.1) [Compare Source](capricorn86/happy-dom@v16.4.0...v16.4.1) ##### 👷‍♂️ Patch fixes - Fixes issue where HTML assigned to `document.documentElement.innerHTML` isnt parsed correctly since v16 - By **[@capricorn86](https://github.com/capricorn86)** in task [#1663](capricorn86/happy-dom#1663) ### [`v16.4.0`](https://github.com/capricorn86/happy-dom/releases/tag/v16.4.0) [Compare Source](capricorn86/happy-dom@v16.3.0...v16.4.0) ##### 🎨 Features - Allow fetch to be intercepted and modified by sending in an interceptor as a setting - By **[@OlaviSau](https://github.com/OlaviSau)** in task [#1502](capricorn86/happy-dom#1502) - Read more about this in the Wiki at [IFetchInterceptor](https://github.com/capricorn86/happy-dom/wiki/IFetchInterceptor) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 1 * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6757 Reviewed-by: Earl Warren <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

viceice added the bug Something isn't working label Jan 3, 2025

capricorn86 self-assigned this Jan 7, 2025

capricorn86 added a commit that referenced this issue Jan 7, 2025

fix: [#1663] Fixes issue where setting document.documentElement.inner…

263ddf7

…HTML isnt parsed correctly since v16

capricorn86 linked a pull request Jan 7, 2025 that will close this issue

fix: [#1663] Fixes issue where setting document.documentElement.innerHTML isnt parsed correctly since v16 #1671

Merged

capricorn86 added a commit that referenced this issue Jan 7, 2025

fix: [#1663] Fixes issue where setting document.documentElement.inner…

00b34b4

…HTML isnt parsed correctly since v16 (#1671)

capricorn86 closed this as completed in #1671 Jan 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

happy-dom v16 with vitest throws: TypeError: Cannot read properties of null (reading 'Symbol(nodeArray)') #1663

happy-dom v16 with vitest throws: TypeError: Cannot read properties of null (reading 'Symbol(nodeArray)') #1663

viceice commented Jan 3, 2025

viceice commented Jan 7, 2025

viceice commented Jan 7, 2025

capricorn86 commented Jan 7, 2025

happy-dom v16 with vitest throws: TypeError: Cannot read properties of null (reading 'Symbol(nodeArray)') #1663

happy-dom v16 with vitest throws: TypeError: Cannot read properties of null (reading 'Symbol(nodeArray)') #1663

Comments

viceice commented Jan 3, 2025

viceice commented Jan 7, 2025

viceice commented Jan 7, 2025

capricorn86 commented Jan 7, 2025