Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint [0] based collection access in FEEL #3604

Closed
1 task
nikku opened this issue May 11, 2023 · 4 comments
Closed
1 task

Lint [0] based collection access in FEEL #3604

nikku opened this issue May 11, 2023 · 4 comments
Labels
Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request feel editing linting
Milestone
M81

Comments

@nikku
Copy link
Member

nikku commented May 11, 2023

Problem you would like to solve

The fact that FEEL starts arrays at index 1 is unexpected for professional developers. We should assist our users that expect [0] to work.

Proposed solution

  • We lint FEEL and detect [0] access, and tell users this is not going to work

Alternatives considered

None.

Additional context

None.
@nikku nikku added enhancement New feature or request Camunda 8 Flags an issue as related to Camunda 8 linting feel editing labels May 11, 2023
@barmac
Copy link
Collaborator

barmac commented May 22, 2023

This makes sense.

@barmac barmac added the backlog Queued in backlog label May 22, 2023
@nikku
Copy link
Member Author

nikku commented Dec 11, 2024

We already did this I believe @barmac?

@nikku nikku added fixed upstream Requires integration of upstream change and removed backlog Queued in backlog labels Dec 11, 2024
@barmac
Copy link
Collaborator

barmac commented Dec 11, 2024 •
edited
Loading

Yes, this was shipped in 5.28.0. I wasn't aware of the Modeler issue.

@barmac barmac closed this as completed Dec 11, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Dec 11, 2024
@github-actions github-actions bot added this to the M84 milestone Dec 11, 2024
barmac added a commit that referenced this issue Dec 11, 2024
@barmac
chore: update changelog
fa7133a 
Added missing #3604 reference in 5.28.0.
@barmac barmac mentioned this issue Dec 11, 2024
Merged
4 tasks
@barmac barmac modified the milestones: M84, M81 Dec 11, 2024
@barmac
Copy link
Collaborator

barmac commented Dec 11, 2024

Added to changelog via #4750
I also updated the milestone of this issue accordingly.

nikku pushed a commit that referenced this issue Dec 11, 2024
@barmac @nikku
chore: update changelog
8610c45 
Added missing #3604 reference in 5.28.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request feel editing linting
Projects
None yet
Milestone
M81
Development

No branches or pull requests
2 participants
@nikku @barmac