Code

Shell package cleanup#3068

Code

Merged

DrJosh9000 merged 18 commits intomainbuildkite/agent:mainfrom pipe-358-shell-refactorbuildkite/agent:pipe-358-shell-refactorCopy head branch name to clipboardNov 7, 2024

+1,135-1,027

Commits

Commits on Nov 7, 2024

• Move internal/job/shell to internal/shell

  DrJosh9000

  committed
  bae1bbe

  Copy full SHA for bae1bbe

• Fix nil panic in signal_windows.go

  DrJosh9000

  committed
  45f0b50

  Copy full SHA for 45f0b50

• Rename GetExitCode to ExitCode

  DrJosh9000

  committed
  683ff23

  Copy full SHA for 683ff23

• Rename WithStdin to CloneWithStdin

  DrJosh9000

  committed
  61ab601

  Copy full SHA for 61ab601

• Remove command struct, simplify process tracking internals

  Show description for e1de24e
  DrJosh9000

  committed
  e1de24e

  Copy full SHA for e1de24e

• Use strings.Builder instead of bytes.Buffer

  DrJosh9000

  committed
  0b84686

  Copy full SHA for 0b84686

• Remove executeFlags, pass stdout/stderr/pty as args

  DrJosh9000

  committed
  e625004

  Copy full SHA for e625004

• Rename LockFile to Unlocker

  DrJosh9000

  committed
  45d802d

  Copy full SHA for 45d802d

• Functional options / unexport Shell fields

  Show description for 26f7194
  DrJosh9000

  committed
  26f7194

  Copy full SHA for 26f7194

• Rearrange output & redactor setup to make data flow clearer

  Show description for 68de265
  DrJosh9000

  committed
  68de265

  Copy full SHA for 68de265

• Clarify RunAndCapture handling of stderr

  DrJosh9000

  committed
  3f188f5

  Copy full SHA for 3f188f5

• Functional options for Run variants

  DrJosh9000

  committed
  126e821

  Copy full SHA for 126e821

• Replace RunWithOlfactor with functional equivalent

  DrJosh9000

  committed
  a3a9f00

  Copy full SHA for a3a9f00

• Replace RunWithEnv with functional equivalent

  DrJosh9000

  committed
  99b954d

  Copy full SHA for 99b954d

• Replace RunWithoutPrompt with functional equivalent

  DrJosh9000

  committed
  e80d0ca

  Copy full SHA for e80d0ca

• Replace RunScript with functional equivalent

  DrJosh9000

  committed
  3d99bef

  Copy full SHA for 3d99bef

• Replace RunAndCapture with functional equivalent

  Show description for 0963cd5
  DrJosh9000

  committed
  0963cd5

  Copy full SHA for 0963cd5

• Replace shell.Run with functional equivalent

  DrJosh9000

  committed
  aace2b6

  Copy full SHA for aace2b6