Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make multi-selection outline an outline feature #944

Closed
misiekhardcore opened this issue Oct 30, 2024 · 0 comments · Fixed by #943
Closed

Make multi-selection outline an outline feature #944

misiekhardcore opened this issue Oct 30, 2024 · 0 comments · Fixed by #943
Assignees
@misiekhardcore
Labels
enhancement New feature or request

Comments

@misiekhardcore
Copy link
Contributor

misiekhardcore commented Oct 30, 2024 •
edited by nikku
Loading

What should we do?

Move the multi-selection outline, currently contained within selection into the outline feature.

Why should we do it?

Currently the visuals of multi selection are handled by SelectionVisuals which is part of selection feature. Selection is a core feature and should not be responsible for handling visual aspects, instead outline is the feature that adds a visual outline, or can be left in the viewer case to not offer such a visual outline.

Why do we need to make changes:

  • better separation of concerns - visuals (outline related) are kept in their own feature, while Selection handles selection mechanics
  • as a user I have full control over whether I want to use the selection, outline, or both features
  • in case of headless usage or the viewer can omit the outline, to use the tool as is, without additional styles and additional rendering dependencies

See also this comment for the initial discussion

Related to bpmn-io/bpmn-js#2135
misiekhardcore added a commit that referenced this issue Oct 30, 2024
@misiekhardcore
refactor: move multi selection outline into separate feature
131e5cb 
related to #944
This was referenced Oct 30, 2024
Closed
Merged
@misiekhardcore misiekhardcore self-assigned this Oct 30, 2024
@misiekhardcore misiekhardcore added in progress Currently worked on ux and removed ux labels Oct 30, 2024
@nikku nikku changed the title Move multi select outline from selection to a separate feature Make multi-selection outline an outline feature Oct 30, 2024
misiekhardcore added a commit that referenced this issue Oct 31, 2024
@misiekhardcore
refactor: move multi selection outline into separate feature
7ac6fea 
related to #944
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 31, 2024
misiekhardcore added a commit that referenced this issue Oct 31, 2024
@misiekhardcore
refactor: move multi selection outline into separate feature
a6f417f 
closes to #944
@nikku nikku added the enhancement New feature or request label Nov 1, 2024
misiekhardcore added a commit that referenced this issue Nov 1, 2024
@misiekhardcore
refactor: move multi selection outline into separate feature
3008466 
closes to #944
misiekhardcore added a commit that referenced this issue Nov 1, 2024
@misiekhardcore
refactor: move multi selection outline into separate feature
d20f509 
closes to #944
misiekhardcore added a commit that referenced this issue Nov 1, 2024
@misiekhardcore
feat: move multi selection outline into separate feature
94fa2e0 
closes to #944
misiekhardcore added a commit that referenced this issue Nov 1, 2024
@misiekhardcore
feat: move multi selection outline into separate feature
3e3d903 
closes to #944
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 1, 2024
@ElRaptorus ElRaptorus mentioned this issue Jan 9, 2025
Merged
ElRaptorus added a commit to 5minds/diagram-js that referenced this issue Feb 4, 2025
@ElRaptorus
Bump to 15.2.4 (#6)
4c383e9 
# Changes 

Siehe Changelog:
https://github.com/bpmn-io/diagram-js/blob/develop/CHANGELOG.md

## 15.2.4

* `FIX`: canvas `autoFocus` must explicitly be enabled
([bpmn-io#956](bpmn-io#956))
* `FIX`: properly integrate `zoomscroll` with canvas focus
([bpmn-io#956](bpmn-io#956))
* `FIX`: properly integrate `movecanvas` with canvas focus
([bpmn-io#956](bpmn-io#956))

## 15.2.3

* `FIX`: adjust search to prioritize start of word and exact matches
([bpmn-io#953](bpmn-io#953))
* `FIX`: ignore whitespace when searching
([bpmn-io#954](bpmn-io#954))

## 15.2.2

* `FIX`: correct `Keyboard#bind` and config types
([bpmn-io#948](bpmn-io#948))

## 15.2.1

* `FIX`: limit overly permissive regex
([bpmn-io#949](bpmn-io#949))

## 15.2.0

* `FIX`: clear selection when opening search pad
([bpmn-io#947](bpmn-io#947))
* `FIX`: correct dangling selection after search pad interaction
([bpmn-io#947](bpmn-io#947))
* `CHORE`: simplify search pad pre-selection behavior
([bpmn-io#947](bpmn-io#947))

## 15.1.0

* `FEAT`: integrate `popup-menu` with `search`
([bpmn-io#932](bpmn-io#932))
* `FEAT`: recognize modern `search` tokens in `search-pad`
([bpmn-io#932](bpmn-io#932))
* `FEAT`: improve `search` types
([bpmn-io#932](bpmn-io#932))
* `FIX`: correctly handle duplicate entries and whitespace in `search`
([bpmn-io#932](bpmn-io#932))
* `FIX`: find `search` terms across all keys
([bpmn-io#932](bpmn-io#932))
* `FIX`: `search` always returns tokens for matched items
([bpmn-io#932](bpmn-io#932))

## 15.0.0

* `FEAT`: make canvas browser selectable
([bpmn-io#659](bpmn-io#659))
* `FEAT`: make keyboard binding implicit
([bpmn-io#661](bpmn-io#661))
* `FEAT`: make multi-selection outline an outline concern
([bpmn-io#944](bpmn-io#944))

### Breaking Changes

* `Keyboard` binding target can no longer be chosen. Configure keyboard
binding via the `keyboard.bind` configuration and rely on keybindings to
work if the canvas has browser focus.
([bpmn-io#661](bpmn-io#661))
* The `Canvas` is now a focusable component, that is recognized
accordingly by the browser, with all benefits for UX and interaction.
Components that pull focus from the `Canvas` during modeling must ensure
to restore the focus (if intended), via `Canvas#restoreFocus`.
([bpmn-io#661](bpmn-io#661))
* The `selection` feature does not provide visual outline by default
anymore. Use the `outline` feature to re-enable it.
([bpmn-io#944](bpmn-io#944))

## 14.11.3

* `CHORE`: simplify viewbox cloning
([bpmn-io#935](bpmn-io#935))

## 14.11.2

* `FIX`: restore search result highlight
([bpmn-io#931](bpmn-io#931))
* `FIX`: correct search result highlight not being removed
([bpmn-io#931](bpmn-io#931))
* `FIX`: do not change zoom when search openes
([bpmn-io#931](bpmn-io#931))

## 14.11.1

_Partially reverts v14.11.0._

* `FIX`: revert `search` integration into popup menu

## 14.11.0

* `FEAT`: add `search` utility
* `FEAT`: sort popup entry search results semantically
([bpmn-io#916](bpmn-io#916))

## 14.10.0

* `FEAT`: align search styling with other popups
([bpmn-io#913](bpmn-io#913))
* `CHORE`: use existing outline in search
([bpmn-io#913](bpmn-io#913))
* `FIX`: only commit search viewport changes on `ENTER`
([bpmn-io#913](bpmn-io#913))

## 14.9.0

* `CHORE`: export types compatible with `verbatimModuleSyntax`
([bpmn-io#927](bpmn-io#927),
[bpmn-io#864](bpmn-io#864))
* `CHORE`: re-compute context pad position next frame
([bpmn-io#920](bpmn-io#920))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@misiekhardcore misiekhardcore

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move multi selection outline into separate feature bpmn-io/diagram-js
2 participants
@nikku @misiekhardcore