-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguish selected element vs. hover #1616
Comments
Could you show a screen capture of the fix you propose? Maybe it is something that is worth adopting. |
Distinguishing hover state vs selection is definitely a topic for improvement. There would be more things to consider here, but switching to a solid line is a good first step. I disagree with the stroke-width of 5px and would suggest 2px instead. That results in: This is a super easy fix and I support this request. |
@christian-konrad @andreasgeier @nikku I fully agree. As discussed with each of you, here is my initial exploration of these possibilities. I would be more than happy to double down on this and create a design specification for us to discuss.
|
@andreasgeier and @currandwyer please talk to each other on this subject. It seems like you are thinking in a similar direction. @currandwyer's proposals in particular will have a great impact on the "finished" look of the models and reduce the cognitive and visual load during modeling. I put this on the roadmap to considered as a later step, but keeping this open for discussion. In case of doing this, I would like to iterate fast, but also deliver a full package of improved modeling experience. |
@christian-konrad I have had some discussions with @nikku on the topic, months ago. I think it is definitely doable within a reasonable scope, but @nikku is the absolute expert on this topic. I suggest considering potentially including hover and selected states for connecting lines in the scope. I will discuss with @andreasgeier next week |
i got aware of this issue over in the eca channel on the drupal slack. first a +1 for the initial suggestion to provide a way to distinguish visually in between the selected and hover state. and i also like the suggestion in the last comment by @currandwyer to increase the size of the handles. in the current version they are really hard to notice.
|
Moving to backlog for the time being. Thanks everyone for the input. |
Not distinguishing both states makes multi-select somehow weird. |
@currandwyer Could you extract your suggestion on improved hover / select states for connections into a separate issue. We'll tackle this in a simple, straight forward manner as suggested by you and @andreasgeier. Everything beyond that I'll treat as out of scope for the moment. |
@nikku please tell me what's the scope in your opinion for now. I agree to put the connections into a seperate issue. But what are you now aiming to do on the node hover + select state? |
@currandwyer Also consider adding your proposal on "improved selection box" (with round corners for the select / hover) as an additional feature request. It will be quite some work to get that incorporated I think and if we want it we'd need to tackle it appropriately (i.e. answer how it would work as a generic arbitrary diagram element concern. |
bpmn-io/diagram-js#640 proposes a straight forward improvement (solid selection outline). |
Closed via b158add. |
Is your feature request related to a problem? Please describe.
When you create an element or select an existing element, a blue dashed border appears around the element. If you click the element again (which unselects the element), the blue dashed border remains if your cursor is hovered over the element. And if an element is selected, but you hover your cursor over another element, they will both have blue dashed borders. For a new user, this could be slightly confusing. Thanks!
Describe the solution you'd like
One solution would be to distinguish selected vs. hover. Hover would remain the blue dashed border, selected could be a more prominent blue solid border:
Describe alternatives you've considered
Another option could be to slightly darken the opacity of the canvas and everything in it – except for the selected item and its sidebar – when an item is selected. That would effectively highlight the element.
The text was updated successfully, but these errors were encountered: