Add support for SeccompDefault setting for k8s 1.25+ #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpculp
approved these changes
Aug 9, 2023
rpkelly
approved these changes
Aug 9, 2023
etungsten
reviewed
Aug 9, 2023
12 tasks
etungsten
reviewed
Aug 9, 2023
etungsten
approved these changes
Aug 9, 2023
Enable RuntimeDefault as the default seccomp profile for all workloads via kubelet-configuration. This is disabled by default.
cartrius-a
force-pushed
the
seccompdefault
branch
from
8d340c9 to
ab2b9e1
Compare
|
Updated README.md per @etungsten's suggestion |
Co-authored-by: Cartrius Phipps <[email protected]>
etungsten
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
🥇
Diff in models:
$ diff -r aws-k8s-1.24/ aws-k8s-1.25/
Only in aws-k8s-1.25/defaults.d: 54-kubernetes-seccomp-default-false.toml
[etung] in sources/models/src [⎇ HEAD](d73a991) [$?]via 🦀 v1.71.0
$ diff -r aws-k8s-1.25/ aws-k8s-1.26/
Only in aws-k8s-1.26/defaults.d: 54-kubernetes-aws-external-cloud-provider.toml
[etung] in sources/models/src [⎇ HEAD](d73a991) [$?]via 🦀 v1.71.0
$ diff -r aws-k8s-1.25/ aws-k8s-1.27/
Only in aws-k8s-1.27/defaults.d: 54-kubernetes-aws-external-cloud-provider.toml
Only in aws-k8s-1.27/defaults.d: 55-kubernetes-aws-credential-provider.toml
cbgbt
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2742
Description of changes:
Enable RuntimeDefault as the default seccomp profile for all workloads via kubelet-configuration. This is disabled by default.
Testing done:
I launched a 1.14.x Bottlerocket AMI and verified
kubernetes.seccomp-defaultsetting was unavailable. After updating to a custom built Bottlerocket image with my changes, the setting could be set usingapiclient set settings.kubernetes.seccomp-default=true. I verified SeccompDefault was equal to true usingkubectl get --raw /api/v1/nodes/<node>/proxy/configz, meaning that RuntimeDefault was being used as the default seccomp profile for the workload. I also rolled back to the older Bottlerocket image through the Admin container and verified the setting was no longer available.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.