kubelet: Add setting to change log level #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
force-pushed
the
kubelet-log-level
branch
2 times, most recently
from
765497e to
c435521
Compare
jpmcb
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
There is a dependency between this PR and #2437. Whichever merges last will have to update the kubelet config template for k8s 1.24.
This adds a new `kubernetes.log-level` setting to allow configuration of the kubelet logging verbosity. With this, an end user can turn up verbosity if they are trying to troubleshoot something, or turn down verbosity if they don't need as many log messages. Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
kubelet-log-level
branch
from
c435521 to
b696d6f
Compare
bcressey
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #1931
Description of changes:
This adds a new
kubernetes.log-levelsetting to allow configuration of the kubelet logging verbosity. With this, an end user can turn up verbosity if they are trying to troubleshoot something, or turn down verbosity if they don't need as many log messages.Testing done:
Created EKS cluster using development build.
Checked
kubeletcommand line arguments fromsystemctl status kubeletand verified no-vsetting.Ran
apiclient set -j '{"kubernetes": {"log-level": 0}}'Ran
apiclient get settings.kubernetesand verified correct value forlog-level.Checked
systemctl status kubeletand verified-v 0was one of the arguments used to launch the process.Ran
journalctl -u kubelet -fand watched output to see if any additional log messages were being emitted.Ran
apiclient set -j '{"kubernetes": {"log-level": 9}}'and checked setting withapiclient get.Checked
systemctl status kubeletand verified-v 9was one of the arguments used to launch the process.Ran
journalctl -u kubelet -fand watched additional recurring log messages showing all activity.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.