pubsys: switch back to simplelog #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpculp
force-pushed
the
back-to-simplelog
branch
from
99fcea3 to
f08cce7
Compare
|
Removed |
bcressey
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Since
env_loggercan only log output all to stderr or to stdout, I switched back tosimplelogto maintain the mixed outputpubsyshad before #2415. Using CombinedLogger, we can spin up two SimpleLoggers with separate levels and filters as needed.Also sorted
Cargo.toml's dependencies as it was getting a little messy.Testing done:
Published the same AMI several times to verify a successful and unsuccessful push.
Also tried publishing a bad endpoint, and the output matched what we had with
env_logger.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.