Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add details about the two default bottlerocket volumes #1588

Merged
merged 1 commit into from
May 20, 2021

Conversation

etungsten
Copy link
Contributor

Issue number:
Addresses #1203

Description of changes:
This documents the uses of the two default Bottlerocket volumes.

Testing done:
N/A

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@etungsten etungsten requested review from tjkirch and samuelkarp May 20, 2021 00:01
@etungsten etungsten force-pushed the volume-documentation branch from 5eda552 to 73d770d Compare May 20, 2021 02:26
@etungsten
Copy link
Contributor Author

Push above addresses @samuelkarp 's comments.

@etungsten etungsten requested a review from samuelkarp May 20, 2021 02:44
@etungsten etungsten force-pushed the volume-documentation branch from 73d770d to 6a3017e Compare May 20, 2021 17:30
@etungsten etungsten linked an issue May 20, 2021 that may be closed by this pull request
@etungsten etungsten force-pushed the volume-documentation branch from 6a3017e to eeab375 Compare May 20, 2021 17:31
@etungsten
Copy link
Contributor Author

etungsten commented May 20, 2021

Pushes above fix grammar errors.

@etungsten etungsten force-pushed the volume-documentation branch from eeab375 to b8315c2 Compare May 20, 2021 18:34
@etungsten
Copy link
Contributor Author

Push above addresses comments by @tjkirch

@etungsten etungsten requested a review from tjkirch May 20, 2021 18:35
This documents the uses of the two default Bottlerocket volumes.
@etungsten etungsten force-pushed the volume-documentation branch from b8315c2 to 8ad7eaf Compare May 20, 2021 19:31
@etungsten
Copy link
Contributor Author

Push above fixes the broken link.

@etungsten etungsten merged commit b3a8dd7 into bottlerocket-os:develop May 20, 2021
@etungsten etungsten deleted the volume-documentation branch May 20, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for documentation on default volumes
4 participants