PropertiesParser: Warn on duplicate samefile properties #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrueger
force-pushed
the
warn-on-duplicate-samefile-properties
branch
from
c32aed2 to
8c94c1f
Compare
within the same .bnd file warn only when pedantic==true includes testcase Signed-off-by: Christoph Rueger <[email protected]>
chrisrueger
force-pushed
the
warn-on-duplicate-samefile-properties
branch
from
8c94c1f to
ad94c49
Compare
|
@kriegfrj @bjhargrave I have tried to incorporate the requested changes of the other PR and also log only when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is code extracted from #6493 and put into this new PR, because the other PR became to large. This mainly because of a misunderstanding of the problems to solve, which just became visible during discussion.
In this PR
This PR solves the problem that a developer might put a header two times inside the same .bnd file.
If it is a larger .bnd file it can be non-obvious to spot and lead to negative suprises. Thus some kind of warning should be displayed.
Pedantic or not
There has been some discussion to only log the warning when in pedantic=true mode.
One reason is that a duplicate header is technically totally legal in a java .properties file (which is what a .bnd file is).
But there is discussion whether this should be semantically allowed for
.bndfiles.This is still to be decided and one reason for this extra PR.