Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dnsjava, use desugaring with nio, refactor DNS resolving #917

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Update dnsjava, use desugaring with nio, refactor DNS resolving #917

merged 7 commits into from
Jul 18, 2024

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Jul 17, 2024 •
edited
Loading

Purpose

Previously, we couldn't use dnsjava 3.x because the java.nio.file.Path API was not available.

Now Android provides desugaring for that class, so we can use dnsjava 3.x and also refactor DNS detection a bit.

Short description

Create DnsRecordResolver + some tests to handle all DNS lookups.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@rfc2822 rfc2822 linked an issue Jul 17, 2024 that may be closed by this pull request
Check dnsjava 3.x compatibility #916
Closed
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Jul 17, 2024
@rfc2822 rfc2822 force-pushed the 916-check-dnsjava-3x-compatibility branch from 080469d to d36783d Compare July 17, 2024 08:06
@rfc2822 rfc2822 force-pushed the 916-check-dnsjava-3x-compatibility branch from d36783d to 580fc44 Compare July 17, 2024 08:25
@rfc2822 rfc2822 self-assigned this Jul 17, 2024
@rfc2822 rfc2822 requested a review from sunkup July 17, 2024 10:32
@rfc2822 rfc2822 marked this pull request as ready for review July 17, 2024 10:32
sunkup
sunkup approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just minor comments/questions. :)

@rfc2822 rfc2822 force-pushed the 916-check-dnsjava-3x-compatibility branch from 71d119f to 7bc22b5 Compare July 18, 2024 08:59
@rfc2822 rfc2822 merged commit 59a57fc into main-ose Jul 18, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 916-check-dnsjava-3x-compatibility branch July 18, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@rfc2822 rfc2822

Labels
refactoring Internal improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check dnsjava 3.x compatibility
2 participants
@rfc2822 @sunkup