Replace DavUtils.lastSegmentOfUrl by UrlUtils.lastSegment

[ArnyminerZ]

The PR should be in Draft state during development. As soon as it's finished, it should be marked as Ready for review and a reviewer should be chosen.

See also: Writing A Great Pull Request Description

Purpose

Replaces all the usages of the deprecated DavUtils.lastSegmentOfUrl by the extension function of Url (lastSegment()).

Short description

• Added replaceWith to the annotation.
• Replaced all usages

DavUtils.lastSegmentOfUrl may be removed if desired.

Checklist

• The PR has a proper title, description and label.
• I have self-reviewed the PR.
• I have added documentation to complex functions and functions that can be used by other modules.
• I have added reasonable tests or consciously decided to not add tests.

[rfc2822]

Looks good. We can already remove the DavUtils.lastSegmentOfUrl.

Then the tests DavUtils.lastSegmentOfUrl for will also have to be moved into UrlUtilsTest and testHttpUrl_lastSegment

[ArnyminerZ]

Also, since lastSegment doesn't have any parameters, I'd replace the function:

fun HttpUrl.lastSegment(): String =
    pathSegments.lastOrNull { it.isNotEmpty() } ?: "/"

by a variable

val HttpUrl.lastSegment: String
    get() = pathSegments.lastOrNull { it.isNotEmpty() } ?: "/"

At the end, for the Java conversion it's the same, but it's shorter to write 😅

[rfc2822]

by a variable

Yes please do so :)

[rfc2822]

Test still fail, probably some minimal thing

[rfc2822]

Still fails