Don't upload event when calendar is read only #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkup
force-pushed
the
572-dont-upload-event-when-calendar-is-read-only
branch
from
2096b64 to
fbb1200
Compare
sunkup
force-pushed
the
572-dont-upload-event-when-calendar-is-read-only
branch
2 times, most recently
from
74c7d21 to
4a654f9
Compare
rfc2822
force-pushed
the
572-dont-upload-event-when-calendar-is-read-only
branch
from
4a654f9 to
fbc6a96
Compare
…nt provider during populate()
rfc2822
force-pushed
the
572-dont-upload-event-when-calendar-is-read-only
branch
from
4428ba7 to
7646e16
Compare
rfc2822
reviewed
Feb 23, 2024
There was a problem hiding this comment.
After having done a few changes (most important one is to get read-only in populate() – unfortunately the ical4android API is not perfect and also not well-documented), I suggest to
- lift
LocalAddress.resetDeleted()up toLocalResource.resetDeleted() -
LocalAddressthen becomes an empty abstract classsuperclassforLocalGroupandLocalContact(needs to stay an interface, because it's impossible to inherit from more than one class,LocalContactinherits already from AndroidContact) - for
LocalCalendar, your new methodmarkAsNotDeleted()will then overrideresetDeleted()instead
rfc2822
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Thanks, looks good and works as expected – this will save us from 403 on read-only calendars.
I'm not sure whether we really want to completely reset the local events on read-only events. It may be a valid use case to adapt the local alarm of otherwise read-only events (like it's possible with Etar).
However this could be topic of a follow-up issue/PR, as well as read-only handling of tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.