Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite BatteryOptimizationsFragment to Compose #580

Merged
merged 19 commits into from
Feb 23, 2024

Conversation

ArnyminerZ
Copy link
Member

No description provided.

@ArnyminerZ ArnyminerZ self-assigned this Feb 17, 2024
@ArnyminerZ ArnyminerZ linked an issue Feb 17, 2024 that may be closed by this pull request
Signed-off-by: Arnau Mora <[email protected]>
@ArnyminerZ ArnyminerZ requested a review from rfc2822 February 17, 2024 17:04
@ArnyminerZ ArnyminerZ marked this pull request as ready for review February 17, 2024 17:04
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ requested a review from rfc2822 February 19, 2024 12:27
@rfc2822 rfc2822 force-pushed the 579-rewrite-batteryoptimizationsfragment-to-compose branch from 50c6853 to 8aef066 Compare February 19, 2024 18:18
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the preview work for you? I always get a "Render problem: Failed to instantiate Composition Local".

…fragment-to-compose' into 579-rewrite-batteryoptimizationsfragment-to-compose

# Conflicts:
#	app/src/main/kotlin/at/bitfire/davdroid/ui/intro/BatteryOptimizationsFragment.kt
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
@ArnyminerZ ArnyminerZ requested a review from rfc2822 February 21, 2024 12:53
@rfc2822 rfc2822 marked this pull request as draft February 21, 2024 16:01
@ArnyminerZ ArnyminerZ marked this pull request as ready for review February 21, 2024 17:37
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Feb 23, 2024
@rfc2822 rfc2822 merged commit be309e1 into dev-ose Feb 23, 2024
7 checks passed
@rfc2822 rfc2822 deleted the 579-rewrite-batteryoptimizationsfragment-to-compose branch February 23, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite BatteryOptimizationsFragment to Compose
2 participants