Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extension not working on windows #57

Merged
merged 3 commits into from
Oct 19, 2024
Merged

fix: extension not working on windows #57

merged 3 commits into from
Oct 19, 2024

Conversation

luckydye
Copy link
Collaborator

Closes #54

  • update zed_extension_api dependency
  • fix invalid biome path on windows
  • refactor code for improved readability (I hope its not too confusing for the PR)

Manually tested on Mac and Windows.

ematipico
ematipico approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, in case you do some refactors, you can add comments later to highlight where the fix is. That will help with any reviews

@luckydye luckydye merged commit aa9a622 into main Oct 19, 2024
3 checks passed
@luckydye luckydye deleted the fix/windows-path branch October 19, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix biome language server start on windows
2 participants
@luckydye @ematipico