Make backup on flash an option

[haslinghuis]

• adds option for backup during flashing (disabled, enabled, ask)
• enabled is default
• add error handling in filesystem API if there is no file handler available
• add error handling for backup process
• increase timeout to enter cli for backup command to reduce corruption of resulting config
• remove some unused messages
• fix parameter for i18n message
• refactor to make sonar happy

[netlify]

✅ Deploy Preview for origin-betaflight-app ready!

Name	Link
🔨 Latest commit	57e3920
🔍 Latest deploy log	https://app.netlify.com/sites/origin-betaflight-app/deploys/67cc80ef491ef10008d7d05e
😎 Deploy Preview	https://deploy-preview-4360.dev.app.betaflight.com
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[haslinghuis]

Sorry need to move default to main.js (as now it adds default in option).

[nerdCopter]

i don't know that i would keep this option ON. (but also like master's current option)
what are some alternatives?

• backup button on bottom of screen before Exit DFU?
• new left-menu tab Backup/Restore?

[haslinghuis]

Perhaps:

• new users rejecting the dialog - not having a backup when flashing new firmware ==> force backup (and keep option ?)
• advanced users want to backup in certain situations ==> keep the dialog (and option so dialog can be disabled)

Not for now:
Thinking about a window for complete Backup - Flash - Restore process (need to keep track of flash process and exceptions)

[nerdCopter]

• meanwhile, is it possible to have master's backup/ignore dialog every flash?
• maybe the option to turn this dialog off
• maybe this is best alternative, but have the dialog more "alert"

[haslinghuis]

@nerdCopter think have addressed your review

[nerdCopter]

please set ask before backup as default

edit: i think enabled by default, pardon my change of mind, it was when the option-save was broken (displaying disabled).

[haslinghuis]

@nerdCopter should overwrite once set. Saves for me (changing or refreshing tab in browser)

[haslinghuis]

Hmmm, works locally but not in preview 🤯

[haslinghuis]

Seems to work now after we accept this dialog

[nerdCopter]

dd00823e
seems to work as expected. let's ask on discord about default = enable vs ask.

edit: in retrospect, i think enabled by default

[haslinghuis]

Rebased on master

[TehllamaFPV]

Testing on my end so far so good. I'll try and put it through the wringer tonight.
I did have some dumb questions about default file locations (i.e. can I set these to exist in a sub-folder), but I'll test those out first.
I need to figure out if having a standalone button on the firmware flasher page (for FCs not in DFU mode) would make sense for 'make backup file in default location, put FC into DFU mode, and select the target from FC as the target, user may now proceed with selection BF version and options [and if doing some javascript to fish for particular things like RX serial providers on separate lists to auto-enable certain options like SBUS/DSMX], probably a separate PR since this is a solid answer to 90% of the problem space.

[VitroidFPV]

All options work as they should.

The only thing I am a little confused about is that when using Backup Enabled, and the file picker dialog is closed, the Configurator won't open the selection for the DFU device (this seems appropriate), but the board stays in DFU mode. It'd be nice (if possible) to automatically exit DFU after that

[nerdCopter]

@VitroidFPV , just in case: if you accidentally click out of chrome, the DFU dialog disappears. refresh seems to be the only answer.

i re-tested your observation by resetting my permissions. refreshing, backup-enabled. canceled the save dialog. STM32 DFU popped up for me. Debain Linux, Chrome.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud