initialize errors HashSet without high initial capacity #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bee-san
requested changes
Apr 6, 2024
|
Hi! Mind pushing an empty commit? CI has failed to pick this up and I think it'll only pick it up on a new commit? 🤔 |
fabianbees
force-pushed
the
reduce_mem_footprint
branch
from
133a4b3 to
138ceed
Compare
|
CI is not running, because the Build-Workflow somehow requires an approval from a maintainer: |
fabianbees
force-pushed
the
reduce_mem_footprint
branch
from
5a84370 to
138ceed
Compare
Yes, that's fine. Before it wasn't running at all, and the emtpy commit kicked GitHub into seeing it had something to do here :) CI is running! |
|
thank you!! |
|
Your welcome! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases it is not expected to have that many errors, which causes an increase of the HashSet, it shouldn't be necessary to pre-allocate that much memory for potential errors.
fixes #447
fixes #523