Only include cargo-auditable installation commands when it's needed. #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duckinator
force-pushed
the
cargo-auditable-then-some
branch
from
9e7a9db to
5fbd507
Compare
duckinator
force-pushed
the
cargo-auditable-then-some
branch
from
5fbd507 to
a90bec7
Compare
mistydemeo
approved these changes
Dec 2, 2024
|
Also looks like this doesn't trip up the undefined behaviour check we added recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #1528, which uses
Option::then_someto avoid includingcargo-auditableinstallation commands when they won't be used.Closes #1569.