fix: standalone updater installation #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
fix-standalone-updaters
branch
3 times, most recently
from
a20e9d1 to
3dde702
Compare
This was broken in a refactor in 19af853. That commit updated how we fetch platform-specific information, but it missed that the `updater` field in the new type is differently-shaped than the field from the new type. Specifically, the new `archive` we're working on has an `updater` field that's an *index into a table of updaters* intead of an *updater struct* - so trying to read its `id` and `bin` fields was doomed to failure. Fixes #1443.
mistydemeo
force-pushed
the
fix-standalone-updaters
branch
from
3dde702 to
3510d08
Compare
mistydemeo
force-pushed
the
fix-standalone-updaters
branch
from
2f3ba33 to
8017bf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken in a refactor in 19af853. That commit updated how we fetch platform-specific information, but it missed that the
updaterfield in the new type is differently-shaped than the field from the new type. Specifically, the newarchivewe're working on has anupdaterfield that's an index into a table of updaters intead of an updater struct - so trying to read itsidandbinfields was doomed to failure.The snapshots in #1346 actually exposed this problem, but both Aria and I missed it in review. We need to be more careful about this in the future.
Fixes #1443.