feat: support app-specific force install #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
approved these changes
Aug 28, 2024
mistydemeo
force-pushed
the
alt_env_var_force
branch
2 times, most recently
from
981150e to
711faef
Compare
This supports a new app-specific force install environment variable. We use the app's name, uppercased and with `-` replaced by `_`. For example, if the app name is `akaikatana-repack`, the new force install environment variable becomes `AKAIKATANA_REPACK_FORCE_INSTALL_DIR`. This supports the new variable alongside the old one. In the longterm, we could consider removing the old one after a transition period where both are supported. An axolotlsay PR to use the new environment variable is here: axodotdev/axoupdater#169 refs #1375.
mistydemeo
force-pushed
the
alt_env_var_force
branch
3 times, most recently
from
80ccefc to
e0b6b6a
Compare
mistydemeo
force-pushed
the
alt_env_var_force
branch
from
e0b6b6a to
701587a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports a new app-specific force install environment variable. We use the app's name, uppercased and with
-replaced by_. For example, if the app name isakaikatana-repack, the new force install environment variable becomesAKAIKATANA_REPACK_FORCE_INSTALL_DIR.This supports the new variable alongside the old one. In the longterm, we could consider removing the old one after a transition period where both are supported.
An axolotlsay PR to use the new environment variable is here: axodotdev/axoupdater#169
refs #1375.