Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dns test #867

Merged
merged 4 commits into from
Mar 6, 2025
Merged

fix: dns test #867

merged 4 commits into from
Mar 6, 2025

Conversation

richarddavison
Copy link
Collaborator

@richarddavison richarddavison commented Mar 4, 2025

Description of changes

Test introduced by #825 had assertions in callbacks of non-asynchronous functions. This will (by design) crash the process if not handled correctly.

Throwing an error in a callback will result in process exit. This PR fixes the assertions by wrapping the lookup in a promise. Another option would be to use the done callback and an inner try catch in the callback.

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@richarddavison richarddavison changed the title Debug windows socket error fix: dns test Mar 6, 2025
@richarddavison richarddavison merged commit f859364 into main Mar 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant