bugfix: ImdsCredentialsProvider: Avoid double slashes in URLs #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected ArtifactsChanged in size
|
ianbotsf
approved these changes
Aug 9, 2024
| { | ||
| "id": "5a460540-14ee-4d26-a860-8cd122323b34", | ||
| "type": "bugfix", | ||
| "description": "ImdsCredentialsProvider: Avoid double slashes in URLs" |
There was a problem hiding this comment.
Nit: Thank you for creating a changelog entry. Please follow the guidelines in the CONTRIBUTING.md doc for description, specifically around use of imperative present tense. For example: "Stop using double slashes in `ImdsCredentialsProvider` URLs"
lauzadis
approved these changes
Aug 9, 2024
argggh
force-pushed
the
argggh/imds-path-concatenation
branch
from
b6da68e to
70397ee
Compare
|
|
Alright this change is merged and should be available in tomorrow's release. |
Great to hear. Thank you for helping move it along, @ianbotsf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The fix to #1303 introduced a change where the
CREDENTIALS_BASE_PATHconstant was updated with a trailing slash. Existing usage of this constant to construct longer paths did not take this into account, leading to double slashes at the concatenation point. Unfortunately,ImdsCredentialsProviderTestdid not assert request matches on its interactions, so this was not caught at the time of change. Change the usage of the base path constant and add request match assertions to hopefully catch new regressions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.