Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Tooltip gets stuck if visible when closing the pane #362

Closed
6 tasks done
Ben3eeE opened this issue Aug 10, 2016 · 6 comments
Closed
6 tasks done

Tooltip gets stuck if visible when closing the pane #362

Ben3eeE opened this issue Aug 10, 2016 · 6 comments
Assignees
Labels

Comments

@Ben3eeE
Copy link
Contributor

Ben3eeE commented Aug 10, 2016

Prerequisites

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.

Description

The tooltip shown when hovering over a tab does not close if it was visible when closing the pane.
Same as #7 only this happens when closing the pane and not the tab.

Steps to Reproduce

  1. Open Atom in safe mode with a multi pane layout.
  2. Hover over one of the open tabs and wait for the tooltip to appear.
  3. Right click and choose close pane from the menu.

tooltip close pane

I have also seen this when closing the pane from the context menu before the tooltip is visible, it then gets stuck in the top left corner.

Expected behavior: Tooltip to close because tab gets closed.

Actual behavior: Tooltip does not close and is always visible.

Versions

You can get this information from executing atom --version and apm --version at the command line. Also, please include the OS and what version of the OS you're running.

Windows 7.

atom --version
Atom    : 1.9.7
Electron: 0.37.8
Chrome  : 49.0.2623.75
Node    : 5.10.0
apm --version
apm  1.10.0
npm  2.13.3
node 0.10.40
python 2.7.11
git 1.9.2.msysgit.0
visual studio
@winstliu
Copy link
Contributor

winstliu commented Aug 10, 2016

Cannot reproduce on Atom 1.11.0-dev-ac75135, Windows 10 x64. I tried using a horizontal split (so left|right). Maybe this is another Classic mode bug?

@Ben3eeE
Copy link
Contributor Author

Ben3eeE commented Aug 10, 2016

Same issue on Windows 10 with Atom 1.10-beta4 and 1.11-dev-bc65aa0 (Electron upgrade branch) so not classic mode bug. I will fool around with settings to see if I can figure out if something specific causes this.

@Ben3eeE
Copy link
Contributor Author

Ben3eeE commented Aug 10, 2016

The tooltip disappears if I resize the Atom window or toggle the menu bar with alt. Stuck otherwise.

@Ben3eeE
Copy link
Contributor Author

Ben3eeE commented Aug 11, 2016

I can't find any specific setting or something causes this, it happens every time I close the pane using the tabs context menu, but not if the pane gets closed in another way for example by closing the last tab with remove empty panes on.

@winstliu
Copy link
Contributor

Can now confirm on Atom 1.12.0-dev-d79690e.

@winstliu
Copy link
Contributor

winstliu commented Oct 5, 2016

This is because the .destroy() function of each tab isn't called when the pane is closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants