Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Add uuid helper for all kinds of unix os #34

Closed
wants to merge 1 commit into from
Closed

Add uuid helper for all kinds of unix os #34

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 9, 2018

Was trying to build on Alpine (aspnet/libuv-package#23) using:

docker run -it microsoft/dotnet:2.1-sdk-alpine

then inside the docker

apk add git bash wget curl ncurses openssl-dev icu-dev libunwind-dev
git clone https://github.com/aspnet/libuv-build
cd $_
./build.sh

There is no uuidgen package/utility available on Alpine and some other distros.

Still some errors from Korebuild, but it's a start.

@natemcmaster
Copy link

Thanks for attempting to start on this. This is one step in the right direction, but there is a lot more work to be done in order to get our Libuv package to support Alpine 3.6, and at the moment, have punted this to 2.2.0 per discussion on aspnet/libuv-package#23. We're not planning on doing the rest of the work in the next few months, so I'm not sure this is something we'll take in right now.

@ghost
Copy link
Author

ghost commented Apr 3, 2018

Thanks @natemcmaster. I had to tweak couple of scripts to make it build. Although, switching from KoreBuild-Legacy to modern aspnet BuildTools would be nice. I can work on it passively.

BTW, if I install libuv from the package manager of OS/distro, shouldn't Kestrel pick up that one by design (or even as a fallback)? Most of the CoreFX native bindings work in this manner without having to build the native so inbox.

@natemcmaster
Copy link

modern aspnet BuildTools would be nice

Indeed. #25 We also had planned to merge this repo and aspnet/libuv-package at some point. But we were waiting to do all this until we actually needed a new version of libuv. We rarely build this code so it's not something we worry about much.

Coreclr uses ldopen on Linux, so yes, it will fallback to system defaults for library locations and honor config like LD_LIBRARY_PATH. See https://github.com/dotnet/dotnet-docker/blob/nightly/2.1/aspnetcore-runtime/alpine/amd64/Dockerfile for example. This is one reason why we decided it was okay to punt rebuilding for alpine.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant