This repository was archived by the owner on Dec 18, 2017. It is now read-only.
Added frameworkAssemblies support #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The frameworkAssemblies section is specific to a target framework - Refactored BuildContext to call into the ProjectReferenceDependencyProvider. This means that only a single place actually uses the project class directly (which is nice). - GetLibraryDescription now takes a Library instead of name and version (we may need to revisit this and create a different poco). When @lodejard finishes dependency types we'll see how this ends up - Preserve the backwards compatibility of declaring frameworkAssemblies in dependencies temporarily - Added tests for parsing frameworkAssemblies #640 #619
|
is this also applicable in the top level dependencies node? |
|
I chose not to make it top level since then future of these are a transitional thing. Nuget packages are the future |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that only a single place actually uses the project class directly
(which is nice).
(we may need to revisit this and create a different poco). When @lodejard finishes
dependency types we'll see how this ends up
dependencies temporarily
Add frameworkAssemblies node to project.json to add gac/reference assemblies #640
Build dependencies should be configurable not fall back to NuGet when missing. #619
/cc @blowdart @GrabYourPitchforks