Skip to content
This repository was archived by the owner on Dec 18, 2017. It is now read-only.

Fix external source files reference with "code" pattern in project.json #614

Merged

Conversation

ChengTian
Copy link
Contributor

  • Reference external source files with forward slashes on Windows works now
  • Reference external source files with backslashes on Mono works now

parent #559

It also doesn't work if you use backslashes in code pattern on Mono to reference source files outside project root. This PR fix the problem at the same time.

@davidfowl
Copy link
Member

After this change goes in and passes, change the sources throughout the asp net vnext repositories to use / instead of \. We'll get tons of coverage this way.

@ChengTian
Copy link
Contributor Author

Sounds great! I can create an issue for it. For such an issue that affects all repositories, should I create it in Home repository?

@davidfowl
Copy link
Member

:shipit: Nope, just do it!

- Reference external source files with forward slashes on Windows works now
- Reference external source files with backslashes on Mono works now
@ChengTian ChengTian force-pushed the fix-external-source-file-reference-with-code-pattern branch from 10f48d4 to c4d28a2 Compare September 9, 2014 22:33
@ChengTian ChengTian merged commit c4d28a2 into dev Sep 9, 2014
@ChengTian ChengTian deleted the fix-external-source-file-reference-with-code-pattern branch September 9, 2014 22:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants