Allow no-throw behavior when command-line parser sees an unexpected option #530
Conversation
|
This needs unit tests verifying that the behavior is fixed and that the previous throwing of invalid arguments for k still throws. |
|
Added unit tests. |
| @@ -166,5 +166,141 @@ public void ShortNamesMayBeDefined() | |||
| Assert.Equal("one", first.Values[0]); | |||
| Assert.Equal("two", second.Values[0]); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
None of these tests seem to define arguments in the test command. Isn't that the main test case?
There was a problem hiding this comment.
This PR is aim to fix the parent issue #520 , which is only related to handling unexpected arguments. Defining an argument in test command is adding an expected argument, which is non-relevant to this issue. Moreover, handling expected argument is already tested here:
https://github.com/aspnet/KRuntime/blob/allow-no-throw-on-unexpected-options/test/Microsoft.Framework.CommandLineUtils.Tests/CommandLineApplicationTests.cs#L32
|
|
parent #520