This repository was archived by the owner on Dec 18, 2017. It is now read-only.
Fix the bug that prevents args from flowing to the program started by "k run" #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -139,7 +138,8 @@ private bool ParseArgs(string[] args, out DefaultHostOptions defaultHostOptions, | |||
| return 0; | |||
| }); | |||
| }, | |||
| addHelpCommand: false); | |||
| addHelpCommand: false, | |||
| throwOnUnexpectedArg: false); | |||
There was a problem hiding this comment.
Because we don't want to report an error when executing k run arg1 arg2. Assume the app in current directory is MyProgram, k run arg1 arg2 should be translated to MyProgram arg1 arg2. Without setting this flag to false, we will get an error message "unexpected argument arg1" output by command-line parser.
There was a problem hiding this comment.
I see, this is specifically for the run command but it works fine for the top level k --foo right?
There was a problem hiding this comment.
Right, it doesn't break error checking in top level k:
PS C:\Users\wwa\Documents\ProjectK\tmp\KRuntime> k --foo
Specify --help for a list of available options and commands.
TODO: Error: unrecognized flag '--foo'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #336