This repository was archived by the owner on Dec 18, 2017. It is now read-only.
Refactor command-line parser and add version flag to k, klr and kpm #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks much better |
|
|
||
| private static string GetVersion() | ||
| { | ||
| var assembly = typeof(RuntimeBootstrapper).GetTypeInfo().Assembly; |
There was a problem hiding this comment.
This logic might be broken on mono. I'll try to verify this
There was a problem hiding this comment.
Since we don't have a Main/Program class as an entry point in this shared project, I chose the RuntimeBootstrapper. Not sure why it might be broken on mono. Please let me know the result after you verify it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #273
Another approach to add version flags. @davidfowl , please help to compare it with the approach in #307