This repository was archived by the owner on Dec 18, 2017. It is now read-only.
Clear the error message after global.json is fixed #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,6 +52,9 @@ public class ApplicationContext | |||
| private readonly CompilationEngineFactory _compilationEngineFactory; | |||
| private int? _contextProtocolVersion; | |||
|
|
|||
| private readonly Message _emptyCleanMessage; | |||
|
So this change isn't what I would expect. I'd expect us to keep track of the last error in the World and update the remote and local world and compare them appropriately like the other things. |
|
The only place we send out "Error" message is in the "catch all" in the processing loop. It is not associated or computed during update the "World". |
|
Updated. Error is registered in remove |
|
⌚ |
|
/cc @davidfowl |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2060
/cc @davidfowl @PradeepKadubandi