This repository was archived by the owner on Dec 18, 2017. It is now read-only.
Show errors when find unsupported framework in project.json #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengTian
force-pushed
the
wei/show-errors-on-unknown-framework
branch
2 times, most recently
from
e90d229 to
3e9d074
Compare
| { | ||
| throw new Exception("TODO: project.json parse error"); | ||
| } | ||
|
|
||
| if (diagnostics.HasErrors()) | ||
| { | ||
| var error = diagnostics.First(x => x.Severity == CompilationMessageSeverity.Error); |
There was a problem hiding this comment.
Could there be multiple errors? What should be the output in that case?
There was a problem hiding this comment.
Good point! It's possible that we have more than one unknown framework. I should turn to AggregateException here, in order to represent multiple errors. Fixed in follow-up commit.
ChengTian
force-pushed
the
wei/show-errors-on-unknown-framework
branch
from
a91d904 to
e379cec
Compare
|
Fixed behavior of |
|
|
ChengTian
force-pushed
the
wei/show-errors-on-unknown-framework
branch
from
e379cec to
4986870
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #1896
@davidfowl @muratg @troydai
Error in VS:
Error in command-line tool (
dnu restore):Error in command-line tool (
dnu build):