Skip to content
This repository was archived by the owner on Dec 18, 2017. It is now read-only.

Bold new behavior #1390

Closed
wants to merge 1 commit into from
Closed

Bold new behavior #1390

wants to merge 1 commit into from

Conversation

BrennanConroy
Copy link
Member

#801

bold

Bold should not compromise the console color you had before running a command
Bold is now the opposite of the starting console color, i.e. Red bolded = dark red, Dark Magenta bolded = Magenta

@ghost
Copy link

ghost commented Mar 12, 2015

Hi @BrennanConroy, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Brennan Conroy). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla2.msopentech.com.

TTYL, MSOTBOT;

@ghost ghost added the cla-not-required label Mar 12, 2015
@@ -15,6 +15,8 @@ private AnsiConsole(TextWriter writer)
OriginalForegroundColor = Console.ForegroundColor;
}

private int BoldRecursion = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fields --> _boldRecursion.

Also, no need to initialize to 0 because that's the default value of an int.

@BrennanConroy
Copy link
Member Author

@bricelam @Eilon

@davidfowl
Copy link
Member

Screenshots on another OS?

@Eilon
Copy link
Member

Eilon commented Mar 23, 2015

:shipit:

@BrennanConroy BrennanConroy deleted the brecon/issue801 branch March 24, 2015 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants