This repository was archived by the owner on Dec 18, 2017. It is now read-only.
Fix kpm commands install folder #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
What does this do? |
|
The bug: |
| @@ -140,7 +140,16 @@ public static AppCommandsFolderRepository CreateDefault() | |||
| { | |||
| userProfileFolder = Environment.GetEnvironmentVariable("HOME"); | |||
| } | |||
| var binFolder = Path.Combine(userProfileFolder, "bin"); | |||
|
|
|||
There was a problem hiding this comment.
Add TODO comments?
// TODO: use Environment.GetFolderPath(Environment.SpecialFolder.UserProfile) when it's available on CoreCLR
|
|
victorhurdugaci
force-pushed
the
commandscorrectfolder
branch
from
79fa490 to
b655ba1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1268
@troydai @ChengTian can you please review
@tugberkugurlu here is the fix if you want to try it :)