This repository was archived by the owner on Dec 18, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 224
DNU restore should still restore unlisted packages #1683
Comments
What? #1208 |
Yes, did you read Jeff's comment in #1208? |
@davidfowl we need to close on the decision here, and perhaps implement it as part of the ongoing nuget work. |
I'm reverting the whole change. We dont have a difference between restore and install. Thats a much bigger discussion. We can potentially warn on restore of an unlisted package. |
@muratg reopening this and moving it to beta6. We need to prefer listed and if that results in no matches, then use unlisted. |
@anurse One of the important ones we should fix. |
analogrelay
added a commit
that referenced
this issue
Jun 29, 2015
...but accepting unlisted packages if there are no matches
analogrelay
added a commit
that referenced
this issue
Jun 30, 2015
...but accepting unlisted packages if there are no matches
analogrelay
added a commit
that referenced
this issue
Jul 1, 2015
...but accepting unlisted packages if there are no matches
analogrelay
added a commit
that referenced
this issue
Jul 1, 2015
...but accepting unlisted packages if there are no matches
analogrelay
added a commit
that referenced
this issue
Jul 1, 2015
...but accepting unlisted packages if there are no matches
analogrelay
added a commit
that referenced
this issue
Jul 1, 2015
analogrelay
added a commit
that referenced
this issue
Jul 1, 2015
...but accepting unlisted packages if there are no matches
analogrelay
added a commit
that referenced
this issue
Jul 2, 2015
...but accepting unlisted packages if there are no matches
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If the Published date value is 1900-01-01T00:00:00 , then the package is unlisted and it should no longer be considered in dependency resolution when versions are being selected, or during initial installs of packages where users are discovering versions.
However, these "unlisted" versions must still be allowed when the user is restoring packages so that the version doesn't disappear out from under them and break their build.
This feature allows package authors to unlist packages for two reasons:
1.The package is being staged for an upcoming release announcement and they want to list the package at the time of the announcement.
2.The package has a very bad bug and the author doesn't want any new users to discover the version that has the bug.
The logic may be different for the v3 feed and we will need to account for that when we add support for v3.
The text was updated successfully, but these errors were encountered: