Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Revert "Auth: Always call prior handlers during Challenge" #1063

Closed
wants to merge 4 commits into from

Conversation

Tratcher
Copy link
Member

#1044 @HaoK
@pranavkm When will the 1.1.1 branches be created?
/cc: @PinpointTownes @brockallen @leastprivilege @blowdart

@Tratcher Tratcher added this to the 1.1.1 milestone Dec 10, 2016
@Tratcher Tratcher self-assigned this Dec 10, 2016
@Tratcher Tratcher requested a review from HaoK December 10, 2016 00:01
@dnfclas
Copy link

dnfclas commented Dec 10, 2016

Hi @Tratcher, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

Copy link
Member

@HaoK HaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than rolling back the entire change, I think we should keep the new test, but update it to verify the old behavior

@Tratcher
Copy link
Member Author

@HaoK Updated

@Tratcher
Copy link
Member Author

Cherry-picked into dev. I'll hold this one until I get confirmation of the branch from @pranavkm.

@Tratcher
Copy link
Member Author

Moving to the rel/1.1.1 branch

@Tratcher Tratcher closed this Jan 19, 2017
@Tratcher Tratcher deleted the tratcher/revert branch January 19, 2017 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants