This repository was archived by the owner on Dec 13, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 599
Revert "Auth: Always call prior handlers during Challenge" #1063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @Tratcher, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
HaoK
suggested changes
Dec 10, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than rolling back the entire change, I think we should keep the new test, but update it to verify the old behavior
8f2c1f1
to
b18dc1c
Compare
@HaoK Updated |
kevinchalet
approved these changes
Dec 14, 2016
HaoK
approved these changes
Dec 14, 2016
Cherry-picked into dev. I'll hold this one until I get confirmation of the branch from @pranavkm. |
b18dc1c
to
e609cda
Compare
Moving to the rel/1.1.1 branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1044 @HaoK
@pranavkm When will the 1.1.1 branches be created?
/cc: @PinpointTownes @brockallen @leastprivilege @blowdart