Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

JwtBearerOptions.SaveToken tests #1768

Closed
Tratcher opened this issue May 23, 2018 · 4 comments
Closed

JwtBearerOptions.SaveToken tests #1768

Tratcher opened this issue May 23, 2018 · 4 comments
Assignees
@Tratcher
Labels
1 - Ready cost: XS Will take about half a day to complete task
Milestone
2.2.0

Comments

@Tratcher
Copy link
Member

SaveToken does not have any tests and it regressed in 2.1. See #1767

@HaoK
@Tratcher Tratcher added task cost: XS Will take about half a day to complete labels May 23, 2018
@HaoK
Copy link
Member

HaoK commented May 23, 2018

Are we sure this regressed in 2.1 as opposed to never working in 2.0? (given that we never had tests :)

@HaoK
Copy link
Member

HaoK commented May 23, 2018

I didn't even realize save tokens was a thing for JwtBearer, I thought it was an OAuth only feature

@muratg muratg added this to the 2.2.0-mq milestone May 24, 2018
@Tratcher Tratcher removed their assignment Jun 1, 2018
@profet23 profet23 mentioned this issue Jul 11, 2018
Closed
@Tratcher
Copy link
Member Author

Tratcher commented Jul 12, 2018 •
edited
Loading

FYI: GoogleTests covers this for the interactive OAuth flow. JwtBearer and OIDC are lacking test coverage though.
It's also covered in the sample apps use for manual testing.

Tratcher added a commit that referenced this issue Jul 12, 2018
@Tratcher
Add JwtBearer test for SaveToken #1768
aef7ff7
@Tratcher Tratcher mentioned this issue Jul 12, 2018
Merged
@Eilon Eilon modified the milestones: 2.2.0-mq, 2.2.0-preview1 Jul 17, 2018
@Eilon Eilon changed the title JwtBeaerOptions.SaveToken tests JwtBearerOptions.SaveToken tests Aug 2, 2018
@Eilon Eilon modified the milestones: 2.2.0-preview3, 2.2.0 Sep 21, 2018
@Eilon
Copy link
Member

Eilon commented Oct 11, 2018

We feel this is a low churn area, so no strong need to add tests for this.

@Eilon Eilon closed this as completed Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tratcher Tratcher

Labels
1 - Ready cost: XS Will take about half a day to complete task
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
4 participants
@Eilon @muratg @Tratcher @HaoK